kbe/calls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sip-provider: Don't leak keyfile

Browse Source 
The reference taken in new_origin_from_keyfile_secret() was never
released in the async callback.
This commit is contained in:
Evangelos Ribeiro Tzaras
2023-04-10 08:29:02 +02:00
parent c84f2a2bd9
commit 208438236c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/provider/sip/calls-sip-provider.c
View File

@@ -164,6 +164,8 @@ on_origin_pw_looked_up (GObject *source,
media_encryption =
(SipMediaEncryption) g_key_file_get_integer (data->key_file, data->name, "MediaEncryption", NULL);
g_key_file_unref (data->key_file);
/* PW */
password = secret_password_lookup_finish (result, &error);
if (!direct_mode && error) {
@@ -218,8 +220,7 @@ new_origin_from_keyfile_secret (CallsSipProvider *self,
data = g_new0 (SipOriginLoadData, 1);
data->provider = self;
g_key_file_ref (key_file);
data->key_file = key_file;
data->key_file = g_key_file_ref (key_file);
data->name = g_strdup (name);
secret_password_lookup (calls_secret_get_schema (), NULL,