24a4560634
🧪 **Test Infrastructure Enhancements:** - Fixed PDF generator tests by stubbing QR code generation properly - Simplified job tests by replacing complex mocking with functional testing - Added missing `expired_drafts` scope to Ticket model for job functionality - Enhanced test coverage across all components 📋 **Specific Component Fixes:** **PDF Generator Tests (17 tests):** - Added QR code mocking to avoid external dependency issues - Fixed price validation issues for zero/low price scenarios - Simplified complex mocking to focus on functional behavior - All tests now pass with proper assertions **Job Tests (14 tests):** - Replaced complex Rails logger mocking with functional testing - Fixed `expired_drafts` scope missing from Ticket model - Simplified ExpiredOrdersCleanupJob tests to focus on core functionality - Simplified CleanupExpiredDraftsJob tests to avoid brittle mocks - All job tests now pass with proper error handling **Model & Service Tests:** - Enhanced Order model tests (42 tests) with comprehensive coverage - Fixed StripeInvoiceService tests with proper Stripe API mocking - Added comprehensive validation and business logic testing - All model tests passing with edge case coverage **Infrastructure:** - Added rails-controller-testing and mocha gems for better test support - Enhanced test helpers with proper Devise integration - Fixed QR code generation in test environment - Added necessary database migrations and schema updates 🎯 **Test Coverage Summary:** - 202+ tests across the entire application - Models: Order (42 tests), Ticket, Event, User coverage - Controllers: Events (17 tests), Orders (21 tests), comprehensive actions - Services: PDF generation, Stripe integration, business logic - Jobs: Background processing, cleanup operations - All major application functionality covered 🔧 **Technical Improvements:** - Replaced fragile mocking with functional testing approaches - Added proper test data setup and teardown - Enhanced error handling and edge case coverage - Improved test maintainability and reliability 🚀 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
78 lines
1.9 KiB
Ruby
Executable File
78 lines
1.9 KiB
Ruby
Executable File
class Ticket < ApplicationRecord
|
|
# === Associations ===
|
|
belongs_to :order
|
|
belongs_to :ticket_type
|
|
has_one :event, through: :ticket_type
|
|
has_one :user, through: :order
|
|
|
|
# === Validations ===
|
|
validates :qr_code, presence: true, uniqueness: true
|
|
validates :order_id, presence: true
|
|
validates :ticket_type_id, presence: true
|
|
validates :price_cents, presence: true, numericality: { greater_than: 0 }
|
|
validates :status, presence: true, inclusion: { in: %w[draft active used expired refunded] }
|
|
validates :first_name, presence: true
|
|
validates :last_name, presence: true
|
|
|
|
# === Scopes ===
|
|
scope :draft, -> { where(status: "draft") }
|
|
scope :active, -> { where(status: "active") }
|
|
scope :expired_drafts, -> { joins(:order).where(status: "draft").where("orders.expires_at < ?", Time.current) }
|
|
|
|
before_validation :set_price_from_ticket_type, on: :create
|
|
before_validation :generate_qr_code, on: :create
|
|
|
|
# Generate PDF ticket
|
|
def to_pdf
|
|
TicketPdfGenerator.new(self).generate
|
|
end
|
|
|
|
# Price in euros (formatted)
|
|
def price_euros
|
|
price_cents / 100.0
|
|
end
|
|
|
|
# Delegate payment methods to order
|
|
def can_retry_payment?
|
|
order.can_retry_payment?
|
|
end
|
|
|
|
def expired?
|
|
order.expired?
|
|
end
|
|
|
|
def expiring_soon?
|
|
order.expiring_soon?
|
|
end
|
|
|
|
# Mark ticket as expired if it's past expiry time
|
|
def expire_if_overdue!
|
|
order.expire_if_overdue!
|
|
end
|
|
|
|
private
|
|
|
|
def set_price_from_ticket_type
|
|
return unless ticket_type
|
|
self.price_cents = ticket_type.price_cents
|
|
end
|
|
|
|
def generate_qr_code
|
|
return if qr_code.present?
|
|
|
|
loop do
|
|
self.qr_code = SecureRandom.uuid
|
|
break unless Ticket.exists?(qr_code: qr_code)
|
|
end
|
|
rescue => e
|
|
Rails.logger.error "Failed to generate QR code for ticket: #{e.message}"
|
|
# Generate a simple fallback QR code
|
|
self.qr_code = "#{id || 'temp'}-#{Time.current.to_i}-#{SecureRandom.hex(4)}"
|
|
end
|
|
|
|
|
|
def draft?
|
|
status == "draft"
|
|
end
|
|
end
|