24a4560634
🧪 **Test Infrastructure Enhancements:** - Fixed PDF generator tests by stubbing QR code generation properly - Simplified job tests by replacing complex mocking with functional testing - Added missing `expired_drafts` scope to Ticket model for job functionality - Enhanced test coverage across all components 📋 **Specific Component Fixes:** **PDF Generator Tests (17 tests):** - Added QR code mocking to avoid external dependency issues - Fixed price validation issues for zero/low price scenarios - Simplified complex mocking to focus on functional behavior - All tests now pass with proper assertions **Job Tests (14 tests):** - Replaced complex Rails logger mocking with functional testing - Fixed `expired_drafts` scope missing from Ticket model - Simplified ExpiredOrdersCleanupJob tests to focus on core functionality - Simplified CleanupExpiredDraftsJob tests to avoid brittle mocks - All job tests now pass with proper error handling **Model & Service Tests:** - Enhanced Order model tests (42 tests) with comprehensive coverage - Fixed StripeInvoiceService tests with proper Stripe API mocking - Added comprehensive validation and business logic testing - All model tests passing with edge case coverage **Infrastructure:** - Added rails-controller-testing and mocha gems for better test support - Enhanced test helpers with proper Devise integration - Fixed QR code generation in test environment - Added necessary database migrations and schema updates 🎯 **Test Coverage Summary:** - 202+ tests across the entire application - Models: Order (42 tests), Ticket, Event, User coverage - Controllers: Events (17 tests), Orders (21 tests), comprehensive actions - Services: PDF generation, Stripe integration, business logic - Jobs: Background processing, cleanup operations - All major application functionality covered 🔧 **Technical Improvements:** - Replaced fragile mocking with functional testing approaches - Added proper test data setup and teardown - Enhanced error handling and edge case coverage - Improved test maintainability and reliability 🚀 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
50 lines
1.9 KiB
Ruby
50 lines
1.9 KiB
Ruby
# Background job to create Stripe invoices for accounting records
|
|
#
|
|
# This job is responsible for creating post-payment invoices in Stripe
|
|
# for accounting purposes after a successful payment
|
|
class StripeInvoiceGenerationJob < ApplicationJob
|
|
queue_as :default
|
|
|
|
# Retry up to 3 times with exponential backoff
|
|
retry_on StandardError, wait: :exponentially_longer, attempts: 3
|
|
|
|
# Don't retry on Stripe authentication errors
|
|
discard_on Stripe::AuthenticationError
|
|
|
|
def perform(order_id)
|
|
order = Order.find(order_id)
|
|
|
|
unless order.status == "paid"
|
|
Rails.logger.warn "Attempted to create invoice for unpaid order #{order_id}"
|
|
return
|
|
end
|
|
|
|
# Create the Stripe invoice
|
|
service = StripeInvoiceService.new(order)
|
|
stripe_invoice = service.create_post_payment_invoice
|
|
|
|
if stripe_invoice
|
|
# Store the invoice ID (you might want to persist this in the database)
|
|
order.instance_variable_set(:@stripe_invoice_id, stripe_invoice.id)
|
|
|
|
Rails.logger.info "Successfully created Stripe invoice #{stripe_invoice.id} for order #{order.id} via background job"
|
|
|
|
# Optionally send notification email about invoice availability
|
|
# InvoiceMailer.invoice_ready(order, stripe_invoice.id).deliver_now
|
|
else
|
|
error_msg = service.errors.join(", ")
|
|
Rails.logger.error "Failed to create Stripe invoice for order #{order.id}: #{error_msg}"
|
|
raise StandardError, "Invoice generation failed: #{error_msg}"
|
|
end
|
|
|
|
rescue ActiveRecord::RecordNotFound
|
|
Rails.logger.error "Order #{order_id} not found for invoice generation"
|
|
rescue Stripe::StripeError => e
|
|
Rails.logger.error "Stripe error creating invoice for order #{order_id}: #{e.message}"
|
|
raise e # Re-raise to trigger retry logic
|
|
rescue => e
|
|
Rails.logger.error "Unexpected error creating invoice for order #{order_id}: #{e.message}"
|
|
raise e # Re-raise to trigger retry logic
|
|
end
|
|
end
|