kevin.bataille/calls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,295 Commits 2 Branches 0 Tags
75cfe07b1414259c97b2102cf0ab0c7a130f0d5b
Commit Graph
170 Commits
Author SHA1 Message Date
Markus GöllnitzandMarge Bot 3d5ff3dbdc contacts-box: adjust search bar's margin inside toolbar 
A toolbar view, per its docs, expects its toolbar
children to either be of a set of known widget types that
are supported by default, or otherwise be a Gtk.Box-like
container with the .toolbar CSS style class.

This expectation was not met, but instead similar, but
not identical margins manually applied. These similar yet
different margins made it look off.

While this now adheres to the toolbar child requirements
of libadwaita, and the margins look more familiar, it
still breaks with libadwaita's assumption that toolbars
are not stacked. Its stylesheet allows for stacking
toolbar views only if one is providing the top and the
other the bottom one.

This view, especially, deserves a more thorough design
overhaul, regardless of this. Thus, I will leave it at
this.

Link: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.ToolbarView.html

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/791>
 2025-10-10 18:37:07 +00:00
Markus GöllnitzandMarge Bot cab52d464c new-call-box: wrap dialer in scrolled window 
It was possible to increase the window's size below the
minimum size of the dialer view. As such it is important
to wrap it in a scrolled window in order not to lose
access to otherwise hidden interface components.

This is, of course, not a replacement for a better
adapting dialer.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/791>
 2025-10-10 18:37:07 +00:00
Markus GöllnitzandMarge Bot f7da8ecfbb main-window: move bottom switcher to toolbar 
The toolbar view is meant for these. This allows
libadwaita's style to apply the way it can be seen in
basically every other GNOME app.

The differences are with the scroll dependent undershoot
instead of an unconditional border.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/791>
 2025-10-10 18:37:07 +00:00
Markus GöllnitzandMarge Bot ba3e0b47ed main-window: increase width of switcher breakpoint 
The current breakpoint is more or less perfect for
English. However, there are other languages with longer
strings there, such as German. Increasing the width at
which the breakpoint sits to switch the switcher location
enables most languages to have no or minimal ellipses
while not looking too spacious with English.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/791>
 2025-10-10 18:37:07 +00:00
Vivek wagdareandEvangelos Ribeiro Tzaras 23b2208c1c contacts-box: Add vertical margins to SearchEntry in contacts view 
Add proper vertical margins (12px) to the SearchEntry widget in the
contacts view to improve spacing and visual consistency. This matches
the existing horizontal margins and follows GNOME design guidelines.

This change improves the visual appearance by preventing the search bar
from appearing cramped, especially when using high-contrast themes.

Closes: https://gitlab.gnome.org/GNOME/calls/-/issues/672
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/762>
 2025-05-24 18:03:09 +02:00
knoppixandMarge Bot ef9db6ce84 main-window.ui: add a proper callback for Close button 
The signal click of Close button is connected to "gtk_widget_hide".
As a result the window is hided, but still active and the whole
program renders unresponsive.

The Close button can appear for example if USSD_STATUS_IDLE comes
before a user press Cancel button in dialog window
(could be for example because of carrier timeout).
The "adw_dialog_close" function should be called instead.

Signed-off-by: knoppix <knoppix@4d2.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/776>
 2025-05-24 15:53:43 +00:00
Guido Günther 7c0fcbc158 call-box: Use correct property 
There's no `selected-index` property. This makes sure we properly switch
between keypad and text entry.

Fixes ee3abc0 ("treewide: Replace libhandy with libadwaita")

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/775>
 2025-04-28 16:19:32 +02:00
Guido Günther d275a1cedc ussd-dialog: Reindent 
Done as a separate commit to ease review

Gbp-Dch: Ignore
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/761>
 2024-11-10 16:53:48 +01:00
Guido Günther 4bd12c1102 ussd-dialog: Use AdwSpinner 
Make it a bit larger while at that

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/761>
 2024-11-10 16:53:48 +01:00
Guido Günther d5cc163801 main-window: Use AdwDialog for USSD 
We grab the focus hence making the text entry easy to identify and by
following the content size we get a reasonable width.

Closes: https://gitlab.gnome.org/GNOME/calls/-/issues/681

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/761>
 2024-11-10 16:53:48 +01:00
Guido Günther 047b5a1495 ussd-dialog: Simplify navigation 
Focus the entry by default so we keep the OSK open when there's
additional input required

Helps: https://gitlab.gnome.org/GNOME/calls/-/issues/681

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/761>
 2024-11-10 16:53:48 +01:00
Guido Günther 39d953c011 ussd-dialog: Set phone input purose on entry 
USSD menus are usually navigatable with dumb phone keyboards
so this makes a good default.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/761>
 2024-11-10 16:53:48 +01:00
Anton LazarevandMarge Bot 7577e85cd9 contacts-box: add .boxed-list CSS class 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/727>
 2024-08-31 20:58:09 +00:00
Anton LazarevandMarge Bot bb4d92f920 call buttons: Add .flat CSS class 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/727>
 2024-08-31 20:58:09 +00:00
Anton LazarevandMarge Bot 2fa17c86d3 main-window: Use AdwBanner for the permanent error label 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/732>
 2024-06-20 12:39:59 +00:00
Anton Lazarev 72e3ae36ba main-window: Change GtkDialog to GtkWindow 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/729>
 2024-05-21 20:27:48 -07:00
Anton Lazarev 27e6b7a9db treewide: Remove requires glade-isms from ui definitions 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:29 -07:00
Anton Lazarev 933655e8e0 new-call-box: Expand to fill horizontal width 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev 8a464224a3 contacts-box: Use AdwToolbarView with search as top bar 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev 9fb5a11c69 contacts-box: Use AdwStatusPage for the placeholder 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev a3a193b77f main-window: Replace AdwViewSwitcherTitle 
https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/migrating-to-breakpoints.html#replace-adwviewswitchertitle

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev 001d599495 treewide: Parent from AdwBin where possible 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev 4fc1374fe8 call-window: Remove superfluous GtkViewport 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev 52b4aa7769 call-record-row: Fix layout 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev eef5b33ad4 call-record-row: Improve event handling 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev caecf10cc1 treewide: Remove visible=True on adwaita widgets 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev 8ea553bd0c call-selector-item: Remove misc unavailable properties 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev b7789a59d1 main-window: Set menu-model directly on the GtkMenuButton 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev 543a55d741 contacts-box: Use title-1 instead of large-title 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev fb93535806 treewide: Use GtkButton:icon-name instead of manual GtkImage child 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 58779b57a3 treewide: image-button style class is automatically handled by GTK 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 87d357729c call-window: receives_default is already true for buttons 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 229bf6f722 treewide: Remove unused placeholder elements 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev c9dc3ceffd treewide: Replace "content" style class with "boxed-list" 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev b83339980b treewide: Use AdwToolbarView for all windows with header bars 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 76697050e8 calls-in-app-notification: migrate to AdwToastOverlay 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 915b855ec8 call-record-row: Accessible role changes 
AtkObject has been removed

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev a2cb767bdc history-box: expand to fill available horizontal space 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 2ee3f347ce main-window: Use menu model for app menu popover 
https://docs.gtk.org/gtk4/migrating-3to4.html#gtkmenu-gtkmenubar-and-gtkmenuitem-are-gone

Unclear why the invisible entries for `Keyboard shortcuts` and `Help`
are there. I've left them ported but commented out for now.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev b32faf39f8 main-window: Replace vbox internal-child with content_area 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 732388303a main-window: Stop setting ::has-default 
https://docs.gtk.org/gtk4/migrating-3to4.html#stop-setting-has-default-and-has-focus-in-ui-files

Oddly, there were previously 2 different default widgets? I just chose
the first one.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 8b57a05836 call-window: Remove no-show-all property 
https://docs.gtk.org/gtk4/migrating-3to4.html#widgets-are-now-visible-by-default

Not sure why it was there in the first place; it was never unset.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:27 -07:00
Anton Lazarev 36f19d5e9f treewide: Remove GtkWindow::hide-titlebar-when-maximized 
https://gitlab.gnome.org/GNOME/gtk/-/commit/92b0d2e8ea8b41ea914eb4d66b48cc7dd2d34b9d

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00
Anton Lazarev a21b2b7d4a treewide: Replace gtk_widget_hide_on_delete with hide-on-close property 
The `delete-event` signal was removed in GTK4.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00
Anton Lazarev ef0b5a9ff8 treewide: Adapt to GtkHeaderBar API changes 
https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-gtkheaderbar-and-gtkactionbar-api-changes

- `show-close-button` replaced with `show_title_buttons` wherever
  applicable, respecting new default value of `TRUE`
- `title` removed and managed by setting window title if needed
    - NOTE: I'm not 100% sure if the title logic here matches the GTK3
      version. I also just removed the SIP account widget titles
      altogether, since it's I couldn't figure out where the widget gets
      placed.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00
Anton Lazarev a236339809 new-call-box: Stop using GtkButton's image-related API 
https://docs.gtk.org/gtk4/migrating-3to4.html#stop-using-gtkbuttons-image-related-api

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00
Anton Lazarev 7c89bbab3d treewide: remove <packing> from Adwaita widgets 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00
Anton Lazarev a656776b19 treewide: Dispose and layout manager implementations 
https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-gtkcontainer-removal

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00
Anton Lazarev 1b567131b7 main-window: Adapt to View Switcher API Changes 
https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/migrating-libhandy-1-4-to-libadwaita.html#adapt-to-view-switcher-api-changes

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00
Anton Lazarev b73016ac8c main-window: Stop using GtkContainer::border-width 
https://docs.gtk.org/gtk4/migrating-3to4.html#stop-using-gtkcontainerborder-width

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00