kevin.bataille/calls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,155 Commits 2 Branches 0 Tags
38ad7dae2a19a681eabad815759bbf90adddea68
Commit Graph
66 Commits
Author SHA1 Message Date
Guido GüntherandMarge Bot 38ad7dae2a call-record-row: Turn the realized check into a critical 
This makes sure we don't ignore it should it happen again.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/756>
 2024-09-21 06:23:20 +00:00
Guido GüntherandMarge Bot 4baa4f5141 call-record-row: Unparent popover in dispose 
Finalize is too late to break reference cycles.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/756>
 2024-09-21 06:23:20 +00:00
Guido GüntherandMarge Bot 08a01fb1c5 call-record-row: Use g_clear_signal_handler 
glib is recent enough nowadays

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/756>
 2024-09-21 06:23:20 +00:00
Guido GüntherandMarge Bot 2f8877b107 call-record-row: Drop superfluous cast 
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/756>
 2024-09-21 06:23:20 +00:00
Evangelos Ribeiro Tzaras b15d557106 record-row: Only popup context menu if row is realized 
This works around the long press gesture
(mis?) firing the "press" signal on a
row that is not realized anymore
(because the slice model in the history box
 currently rebuilds all rows when the items change).

Fixes: https://gitlab.gnome.org/GNOME/calls/-/issues/666
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/755>
 2024-09-14 17:43:15 +02:00
Evangelos Ribeiro Tzaras d9e6fb3717 record-row: Prefer g_signal_connect_object() over a plain connect() 
Apparently the slice list model in the history box
rebuilds the whole list when a single new record gets added.

Additionally, the "pressed" signal gets emitted on the
GtkGestureLongPress controller even when the call button is tapped
(i.e. should not have been pressed down for longer than the required timeout).
This then causes the callback to be invoked with a disposed record row.

This commit ensures the signals get properly disconnected
even in the face of unforeseen cleanup of the record row.

Helps with https://gitlab.gnome.org/GNOME/calls/-/issues/666

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/755>
 2024-09-14 17:42:51 +02:00
Evangelos Ribeiro Tzaras f810e0a9b1 tree: Remove custom clearing macros 
The macros was emulating g_clear_handle_id() and friends
let's use the glib functions directly instead.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/755>
 2024-09-14 11:59:27 +02:00
Evangelos Ribeiro Tzaras 3b1cf7b5ee record-row: Prefer g_autoptr for GDateTime 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/755>
 2024-09-14 11:40:35 +02:00
Evangelos Ribeiro Tzaras 03a50260ec history-box: Add debug statement 
This helps in debugging in debugging
why the slice list model rebuilds the whole list
when a single call gets added.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/755>
 2024-09-14 11:40:35 +02:00
Evangelos Ribeiro Tzaras 9dfaac19cc record-row: Define log domain 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/755>
 2024-09-14 11:40:35 +02:00
Evangelos Ribeiro Tzaras 32b8995f2d record-row: Remove unnecessary cast 
g_object_get() wants a gpointer,
so there is no need for casting to GObject*.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/755>
 2024-09-14 11:40:35 +02:00
Anton Lazarev eef5b33ad4 call-record-row: Improve event handling 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:28 -07:00
Anton Lazarev 27c2f62dc1 calls-call-record-row: Stop using Gtk.Widget::popup-menu 
Removed in GTK4... I don't know if there's a replacement for it at the
moment.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:26 -07:00
Anton Lazarev b85d7efc4f calls-call-record-row: migrate button-press-event to GtkGestureClick 
https://docs.gtk.org/gtk4/migrating-3to4.html#stop-using-gtkwidget-event-signals

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:25 -07:00
Anton Lazarev 669568869c calls-call-record-row: Adapt to event controller API changes 
https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-event-controller-api-changes

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:25 -07:00
Anton Lazarev 2618620124 calls-call-record-row: Adapt to GtkPopover changes 
https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-gtkpopover-changes

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:25 -07:00
Anton Lazarev 12b78ca5f6 calls-best-match: AdwAvatar API changes 
https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/migrating-libhandy-1-4-to-libadwaita.html#adapt-to-adwavatar-api-changes

This is *not* ideal, since it relies on Folks returning a GFileIcon
internally, and it's also blocking. However, better to use something
simple that compiles and works to begin with.

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:24 -07:00
Anton Lazarev 52a0963e6c treewide: Remove icon size from constructors 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:24 -07:00
Anton Lazarev 10b0672f9e treewide: Remove GtkEventBox 
https://docs.gtk.org/gtk4/migrating-3to4.html#stop-using-gtkeventbox

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:24 -07:00
Anton Lazarev ee3abc009a treewide: Replace libhandy with libadwaita 
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
 2024-04-06 08:15:24 -07:00
Evangelos Ribeiro Tzaras bb6b76107c build: Rename util.{c,h} to calls-util.{c,h} 
"util" is a very generic name. This guards against accidentally
including similarly named headers from elsewhere.
 2023-01-22 07:33:02 +00:00
Evangelos Ribeiro Tzaras a52a2a39f8 record-row: Defer enabling popup actions until displaying 
There is no need to enable or disable actions until the popover
is actually presented.

This also get's rid of having to be notified of changes to the
"can-add-contact" property which led to a segfault as the signal handler
was not properly cleared.

Fixes: #535

As the "can-add-contact" property is now always checked,
the menu item will be properly shown.

Fixes: #485
 2022-12-31 18:37:08 +01:00
Evangelos Ribeiro Tzaras 757351b39c record-row: Add SMS action 
Add a menu entry in the history popover to open the default "sms" URI
handler.

Closes: #182
 2022-08-05 10:30:06 +02:00
Evangelos Ribeiro Tzaras 01f3757ce1 record-row: Simplify add-action logic 
Get rid of some code by avoiding special casing
and potentially fix an issue (WIP).
 2022-08-05 10:30:06 +02:00
Evangelos Ribeiro Tzaras 0d6095b42a record-row: Use STR_IS_NULL_OR_EMPTY macro 2022-08-05 10:30:06 +02:00
Evangelos Ribeiro Tzaras 8e23d77508 record-row: Chain up early to constructed() 2022-08-05 10:30:06 +02:00
Evangelos Ribeiro Tzaras d94792f3c5 record-row: Rename callback to conform to on_* naming scheme 2022-08-05 10:30:06 +02:00
Evangelos Ribeiro Tzaras 37eba7b66f record-row: Remove unused code 2022-08-05 10:30:06 +02:00
Evangelos Ribeiro Tzaras 7ac862155b Uncrustify sources 
Ran `find src plugins -iname '*.[c|h]' -print0 | xargs -0 uncrustify --no-backup`
with some minimal manual intervention.
 2022-04-24 12:59:42 +02:00
Evangelos Ribeiro Tzaras 134c4af9c7 record-row: Avoid raising critical 
When the record has a NULL id there won't be a CallsBestMatch we can use to bind
properties.
 2022-03-04 18:00:32 +01:00
Evangelos Ribeiro Tzaras 5b171bf2c5 record-row: Handle calls with NULL id gracefully 
Shuffles some code around so that the property bindings are at the end.
This allows us to return early if there is a NULL contact (as is the case
for anonymous callers).
 2022-02-18 10:55:53 +01:00
Evangelos Ribeiro Tzaras cd075d9269 record-row: Use primary info instead of name property 
RECHECK if bestmatch can ever have a NULL id!
 2022-02-18 10:55:53 +01:00
Evangelos Ribeiro Tzaras 896af6f8af record-row: Fix passing widget instead of string as action target 
When introducing the per protocol dial actions we started setting the widget
self->target as the action target instead of the target property of
self->record.

Bizzarely we only sometimes got greeted with a critical:

11:30:20.5184                 GLib[887977]:CRITICAL: g_variant_new_string: assertion 'g_utf8_validate (string, -1, NULL)' failed

Thread 1 "gnome-calls" received signal SIGTRAP, Trace/breakpoint trap.
g_logv (log_domain=0x7ffff7ea400e "GLib", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=<optimized out>) at ../../../glib/gmessages.c:1417
1417	../../../glib/gmessages.c: No such file or directory.
(gdb) bt
    at ../../../glib/gmessages.c:2898

Fixes: 687dd7ff383476523ae0a8a38879a171cb0b9a5a
Closes #398
 2022-02-01 23:28:50 +01:00
Evangelos Ribeiro Tzaras 423ce4668e record-row: Remove unnecessary G_OBJECT cast 2022-02-01 23:28:50 +01:00
Evangelos Ribeiro Tzaras b00deccdcb record-row: Use per protocol dial action 
This allows us to deactivate actions if there is no origin that can handle them.

Closes #293
 2022-01-31 17:08:38 +00:00
Evangelos Ribeiro Tzaras 827594dc2e record-row: Add context menu entry for adding a new contact 
Fixes #157
 2022-01-18 02:12:37 +00:00
Evangelos Ribeiro Tzaras 4df3ea005d record-row: Only create popover when needed 
Creating a popover for each CallsCallRecordRow comes with a big performance
hit when scrolling the history, so we should avoid doing this.

Fixes #198
 2021-12-10 18:12:30 +01:00
Evangelos Ribeiro Tzaras 42b5b9d600 record-row: Use API to query call icon name 
This makes sure we don't need to allocate icon string names for each record.
 2021-12-07 11:05:12 +01:00
Evangelos Ribeiro Tzaras 625b26be32 record-row: Codestyle 2021-12-07 11:05:12 +01:00
Evangelos Ribeiro Tzaras f206b7d257 call: Rename property from "number" to "id" 
The term number is not necessarily accurate when dealing with f.e. SIP.
 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 989a52fac5 record-row: Removed unused define 2021-11-25 19:14:42 +01:00
Evangelos Ribeiro Tzaras 76ec1e6941 record-row: Use avatars in history 
Fixes #147
 2021-11-18 12:15:25 +01:00
Evangelos Ribeiro Tzaras 57ec06a6f5 record-row: Take timezone into account for displaying in the UI 
Since the database uses UTC times we have to take the timezone offset into
account when displaying times in the UI.

Fixes #163
 2021-10-15 18:14:39 +02:00
Evangelos Ribeiro TzarasandEvangelos Ribeiro Tzaras 6e371d2f3f resources: Use /org/gnome prefix and adapt to changes 
In preparation to moving to GNOME all the IDs, DBus object paths, etc should
change.
 2021-07-12 13:35:57 +00:00
Julian SparberandEvangelos Ribeiro Tzaras 293227ff3c CallsCallRecordRow: Cleanup contact setup 2021-02-03 23:58:31 +00:00
Julian SparberandEvangelos Ribeiro Tzaras f61ae1cba1 Contacts: replace CallsContacts with CallsContactsProvider 2021-02-03 23:28:56 +01:00
Evangelos Ribeiro Tzaras 9f295a729b record-row: hide copy number menu item 
for anonymous callers
 2021-01-20 11:47:33 +00:00
Evangelos Ribeiro Tzaras 78a47918be record-row: Allow copying number from context menu 2021-01-20 11:47:33 +00:00
Adrien PlazasandJulian Sparber 6dba2c453b Port to libhandy 1 
This ports Calls to libhandy 1 and drops the embedded HdyAvatar in favor
of the libhandy one.

Fixes https://source.puri.sm/Librem5/calls/-/issues/172
 2020-10-06 14:06:51 +00:00
Guido GüntherandGuido Gunther b95de5c9e0 calls-call-record-row: Ignore anonymous callsers 
These have an empty string which leads to

    Error parsing phone number `': Keine Telefonnumme
 2020-07-22 06:52:07 +00:00