Use correct parent class when chaining up overridden functions
How `g_type_class_peek ()` was used it didn't return the correct parent class in most cases. G_DEFINE_TYPE macro creates a pointer we can use to get the parent class `n_p_parent_class`. Because we didn't use the correct parent class the object initialisation wasn't fully completed for some GtkWidgets. See https://developer.gnome.org/gobject/stable/chapter-gobject.html#gobject-instantiation for more information. This commit makes use of the `n_p_parent_class pointer` created for this specific use case where ever possible. Fixes: https://source.puri.sm/Librem5/calls/issues/118
This commit is contained in:
@@ -98,7 +98,6 @@ set_property (GObject *object,
|
||||
static void
|
||||
finalize (GObject *object)
|
||||
{
|
||||
GObjectClass *parent_class = g_type_class_peek (G_TYPE_OBJECT);
|
||||
CallsEnumerateParams *self = CALLS_ENUMERATE_PARAMS (object);
|
||||
|
||||
unsigned i;
|
||||
@@ -107,7 +106,7 @@ finalize (GObject *object)
|
||||
g_hash_table_unref (self->callbacks[i]);
|
||||
}
|
||||
|
||||
parent_class->finalize (object);
|
||||
G_OBJECT_CLASS (calls_enumerate_params_parent_class)->finalize (object);
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user