kbe/calls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sip: origin: Make go_online() a no-op in the direct connection case

Browse Source 
This avoids some special casing in init_sip_account()
This commit is contained in:
Evangelos Ribeiro Tzaras
2022-01-10 16:32:45 +01:00
parent 6d877fd9d3
commit d5fd098479
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/sip/calls-sip-origin.c
View File

@@ -913,6 +913,9 @@ go_online (CallsAccount *account,
self = CALLS_SIP_ORIGIN (account); self = CALLS_SIP_ORIGIN (account);
if (self->use_direct_connection)
return;
if (!self->nua) { if (!self->nua) {
g_warning ("Cannot go online: nua handle not initialized"); g_warning ("Cannot go online: nua handle not initialized");
g_object_notify_by_pspec (G_OBJECT (self), props[PROP_ACC_STATE]); g_object_notify_by_pspec (G_OBJECT (self), props[PROP_ACC_STATE]);
@@ -1038,10 +1041,10 @@ init_sip_account (CallsSipOrigin *self,
self->state = CALLS_ACCOUNT_ONLINE; self->state = CALLS_ACCOUNT_ONLINE;
else { else {
self->state = CALLS_ACCOUNT_OFFLINE; self->state = CALLS_ACCOUNT_OFFLINE;
}
if (self->auto_connect) if (self->auto_connect)
go_online (CALLS_ACCOUNT (self), TRUE); go_online (CALLS_ACCOUNT (self), TRUE);
}
g_object_notify_by_pspec (G_OBJECT (self), props[PROP_ACC_STATE]); g_object_notify_by_pspec (G_OBJECT (self), props[PROP_ACC_STATE]);
return TRUE; return TRUE;