kbe/calls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm-origin: Disable call waiting

Browse Source 
As Calls cannot deal with call waiting we should disable it entirely.
This works around issues where call audio get's completely broken once
the waiting call is disconnected on the BM818 modem shipped with the
Librem 5.

See https://source.puri.sm/Librem5/OS-issues/-/issues/311
This commit is contained in:
Evangelos Ribeiro Tzaras
2023-01-19 11:46:48 +01:00
parent 72a85d62fa
commit 205f691570
1 changed files with 59 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
plugins/provider/mm/calls-mm-origin.c
View File

@@ -791,6 +791,60 @@ get_sim_ready_cb (MMModem *modem,
} }
static void
call_waiting_setup_cb (GObject *obj,
GAsyncResult *res,
gpointer user_data)
{
g_autoptr (GError) error = NULL;
g_autoptr (CallsMMOrigin) self = NULL;
MMModemVoice *voice = MM_MODEM_VOICE (obj);
g_assert (CALLS_IS_MM_ORIGIN (user_data));
self = CALLS_MM_ORIGIN (user_data);
g_assert (voice == self->voice);
if (!mm_modem_voice_call_waiting_setup_finish (voice, res, &error)) {
g_warning ("Could not disable call waiting: %s", error->message);
return;
}
g_info ("Disabled call waiting on modem '%s'", self->name);
}
static void
call_waiting_query_cb (GObject *obj,
GAsyncResult *res,
gpointer user_data)
{
g_autoptr (GError) error = NULL;
g_autoptr (CallsMMOrigin) self = NULL;
MMModemVoice *voice = MM_MODEM_VOICE (obj);
gboolean waiting;
g_assert (CALLS_IS_MM_ORIGIN (user_data));
self = CALLS_MM_ORIGIN (user_data);
g_assert (voice == self->voice);
if (!mm_modem_voice_call_waiting_query_finish (voice, res, &waiting, &error)) {
g_warning ("Could not query call waiting status: %s", error->message);
return;
}
g_debug ("Call waiting is %sabled", waiting ? "en" : "dis");
if (waiting) {
g_info ("Disabling call waiting: Not implemented");
mm_modem_voice_call_waiting_setup (voice,
FALSE,
NULL,
call_waiting_setup_cb,
g_steal_pointer (&self));
}
}
static void static void
constructed (GObject *object) constructed (GObject *object)
{ {
@@ -815,6 +869,11 @@ constructed (GObject *object)
self->voice = mm_object_get_modem_voice (self->mm_obj); self->voice = mm_object_get_modem_voice (self->mm_obj);
g_assert (self->voice != NULL); g_assert (self->voice != NULL);
mm_modem_voice_call_waiting_query (self->voice,
NULL,
call_waiting_query_cb,
g_object_ref (self));
g_signal_connect (self->voice, "call-added", g_signal_connect (self->voice, "call-added",
G_CALLBACK (call_added_cb), self); G_CALLBACK (call_added_cb), self);
g_signal_connect (self->voice, "call-deleted", g_signal_connect (self->voice, "call-deleted",