From 06076a864a78a0b50b2ca67f1fcad4abeeb6749e Mon Sep 17 00:00:00 2001
From: Evangelos Ribeiro Tzaras <evangelos.tzaras@puri.sm>
Date: Sun, 2 May 2021 02:35:42 +0200
Subject: [PATCH] sip: media-pipeline: Fix memory leak in error path

---
 plugins/sip/calls-sip-media-pipeline.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/plugins/sip/calls-sip-media-pipeline.c b/plugins/sip/calls-sip-media-pipeline.c
index 0052ae3..288fb75 100644
--- a/plugins/sip/calls-sip-media-pipeline.c
+++ b/plugins/sip/calls-sip-media-pipeline.c
@@ -569,7 +569,7 @@ initable_init (GInitable    *initable,
   if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK) {
     g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
                  "Failed to link rtpsrc to rtpbin");
-    return FALSE;
+    goto err;
   }
   gst_object_unref (srcpad);
   gst_object_unref (sinkpad);
@@ -579,7 +579,7 @@ initable_init (GInitable    *initable,
   if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK) {
     g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
                  "Failed to link rtcpsrc to rtpbin");
-    return FALSE;
+    goto err;
   }
   gst_object_unref (srcpad);
   gst_object_unref (sinkpad);
@@ -589,7 +589,7 @@ initable_init (GInitable    *initable,
   if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK) {
     g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
                  "Failed to link rtpbin to rtcpsink");
-    return FALSE;
+    goto err;
   }
   gst_object_unref (srcpad);
   gst_object_unref (sinkpad);
@@ -605,7 +605,7 @@ initable_init (GInitable    *initable,
   if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK) {
     g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
                  "Failed to link payloader to rtpbin");
-    return FALSE;
+    goto err;
   }
   gst_object_unref (srcpad);
   gst_object_unref (sinkpad);
@@ -616,7 +616,7 @@ initable_init (GInitable    *initable,
   if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK) {
     g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
                  "Failed to link rtpbin to rtpsink");
-    return FALSE;
+    goto err;
   }
   gst_object_unref (srcpad);
   gst_object_unref (sinkpad);
@@ -627,7 +627,7 @@ initable_init (GInitable    *initable,
   if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK) {
     g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
                  "Failed to link rtpbin to rtcpsink");
-    return FALSE;
+    goto err;
   }
   gst_object_unref (srcpad);
   gst_object_unref (sinkpad);
@@ -638,12 +638,18 @@ initable_init (GInitable    *initable,
   if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK) {
     g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
                  "Failed to link rtcpsrc to rtpbin");
-    return FALSE;
+    goto err;
   }
   gst_object_unref (srcpad);
   gst_object_unref (sinkpad);
 
   return TRUE;
+
+ err:
+  gst_object_unref (srcpad);
+  gst_object_unref (sinkpad);
+
+  return FALSE;
 }