- Removed unused JavaScript controllers (shadcn_test, featured_event, event_form, ticket_type_form) - Removed unused React components (button.jsx and utils.js) - Removed duplicate env.example file - Removed unused Alpine.js dependencies from package.json - Updated controller registrations and dependency files - Added REFACTORING_SUMMARY.md with details of changes - Added new file: app/controllers/api/v1/orders_controller.rb
2.4 KiB
2.4 KiB
Code Cleanup Summary
This document summarizes the cleanup work performed to remove redundant and unused code from the Aperonight project.
Files Removed
Unused JavaScript Controllers
app/javascript/controllers/shadcn_test_controller.js- Test controller for shadcn components that was not registered or usedapp/javascript/controllers/featured_event_controller.js- Controller for featured events that was not registered or usedapp/javascript/controllers/event_form_controller.js- Controller for event forms that was not used in any viewsapp/javascript/controllers/ticket_type_form_controller.js- Controller for ticket type forms that was not used in any views
Unused React Components
app/javascript/components/button.jsx- Shadcn-style button component that was not used in production codeapp/javascript/lib/utils.js- Utility functions only used by the button component
Configuration Files
env.example- Duplicate environment example file (keeping.env.exampleas the standard)
Dependencies Removed
Alpine.js Dependencies
Removed unused Alpine.js dependencies from package.json:
alpinejs@types/alpinejs
These dependencies were not being used in the application, as confirmed by:
- No imports in the codebase
- No usage in views
- Commented out initialization code in
application.js
Files Modified
Controller Registration
Updated app/javascript/controllers/index.js to remove registrations for the unused controllers:
- Removed
EventFormControllerregistration - Removed
TicketTypeFormControllerregistration
Package Management Files
Updated dependency files to reflect removal of Alpine.js:
package.json- Removed Alpine.js dependenciespackage-lock.json- Updated vianpm installyarn.lock- Updated viayarn installbun.lock- Updated
Verification
All tests pass successfully after these changes:
- 200 tests executed
- 454 assertions
- 0 failures
- 0 errors
- 0 skips
JavaScript build completes successfully:
app/assets/builds/application.js- 563.0kbapp/assets/builds/application.js.map- 3.0mb
Impact
This cleanup reduces:
- Codebase complexity by removing unused code
- Bundle size by removing unused dependencies
- Maintenance overhead by eliminating dead code
- Potential security vulnerabilities by removing unused dependencies
The application functionality remains unchanged as all removed code was truly unused.