Fix modal overlay issue and improve modal structure

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

app/javascript/controllers/event_duplication_controller.js

@@ -1,27 +1,23 @@
 import { Controller } from "@hotwired/stimulus"
 
 export default class extends Controller {
-  static targets = ["modal", "cloneTicketTypes"]
+  static targets = ["cloneTicketTypes"]
   static values = {
     duplicateUrl: String
   }
 
   connect() {
-    // Close modal when clicking outside
-    this.modalTarget.addEventListener('click', (event) => {
-      if (event.target === this.modalTarget) {
-        this.close()
-      }
-    })
+    // Get modal element from the document
+    this.modalElement = document.querySelector('[data-event-duplication-target="modal"]')
   }
 
   open() {
-    this.modalTarget.classList.remove('hidden')
+    this.modalElement.classList.remove('hidden')
     document.body.classList.add('overflow-hidden')
   }
 
   close() {
-    this.modalTarget.classList.add('hidden')
+    this.modalElement.classList.add('hidden')
     document.body.classList.remove('overflow-hidden')
   }
 

app/views/promoter/events/show.html.erb

@@ -1,52 +1,6 @@
 <% content_for(:title, @event.name) %>
 
 <div data-controller="event-duplication" data-event-duplication-duplicate-url-value="<%= duplicate_promoter_event_path(@event) %>">
-  <!-- Modal -->
-  <div data-event-duplication-target="modal" class="fixed inset-0 z-50 hidden overflow-y-auto">
-    <div class="flex items-end justify-center min-h-screen pt-4 px-4 pb-20 text-center sm:block sm:p-0">
-      <!-- Background overlay -->
-      <div class="fixed inset-0 bg-gray-500 bg-opacity-75 transition-opacity" aria-hidden="true"></div>
-
-      <!-- Modal container -->
-      <div class="inline-block align-bottom bg-white rounded-lg text-left overflow-hidden shadow-xl transform transition-all sm:my-8 sm:align-middle sm:max-w-lg sm:w-full">
-        <div class="bg-white px-4 pt-5 pb-4 sm:p-6 sm:pb-4">
-          <div class="sm:flex sm:items-start">
-            <div class="mx-auto flex-shrink-0 flex items-center justify-center h-12 w-12 rounded-full bg-blue-100 sm:mx-0 sm:h-10 sm:w-10">
-              <i data-lucide="copy" class="h-6 w-6 text-blue-600"></i>
-            </div>
-            <div class="mt-3 text-center sm:mt-0 sm:ml-4 sm:text-left">
-              <h3 class="text-lg leading-6 font-medium text-gray-900" id="modal-title">
-                Dupliquer l'événement
-              </h3>
-              <div class="mt-2">
-                <p class="text-sm text-gray-500">
-                  Choisissez les options de duplication pour "<%= @event.name %>".
-                </p>
-                
-                <div class="mt-4">
-                  <div class="flex items-center">
-                    <input data-event-duplication-target="cloneTicketTypes" id="cloneTicketTypes" type="checkbox" class="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" checked>
-                    <label for="cloneTicketTypes" class="ml-2 block text-sm text-gray-900">
-                      Dupliquer également les types de billets (<%= @event.ticket_types.count %> type(s))
-                    </label>
-                  </div>
-                </div>
-              </div>
-            </div>
-          </div>
-        </div>
-        <div class="bg-gray-50 px-4 py-3 sm:px-6 sm:flex sm:flex-row-reverse">
-          <button type="button" data-action="click->event-duplication#duplicate" class="w-full inline-flex justify-center rounded-md border border-transparent shadow-sm px-4 py-2 bg-blue-600 text-base font-medium text-white hover:bg-blue-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-blue-500 sm:ml-3 sm:w-auto sm:text-sm">
-            Dupliquer
-          </button>
-          <button type="button" data-action="click->event-duplication#close" class="mt-3 w-full inline-flex justify-center rounded-md border border-gray-300 shadow-sm px-4 py-2 bg-white text-base font-medium text-gray-700 hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500 sm:mt-0 sm:ml-3 sm:w-auto sm:text-sm">
-            Annuler
-          </button>
-        </div>
-      </div>
-    </div>
-  </div>
-
   <div class="max-w-6xl mx-auto px-4 sm:px-6 lg:px-8 py-8">
 
   <!-- Breadcrumb -->
@@ -334,4 +288,52 @@
       </div>
     </div>
   </div>
+
+  <!-- Modal -->
+  <div data-event-duplication-target="modal" class="hidden relative z-50" aria-labelledby="modal-title" role="dialog" aria-modal="true">
+    <!-- Background backdrop, show/hide based on modal state -->
+    <div class="fixed inset-0 bg-gray-500 bg-opacity-75 transition-opacity"></div>
+
+    <div class="fixed inset-0 z-50 overflow-y-auto">
+      <div class="flex min-h-full items-end justify-center p-4 text-center sm:items-center sm:p-0">
+        <!-- Modal container -->
+        <div class="relative transform overflow-hidden rounded-lg bg-white text-left shadow-xl transition-all sm:my-8 sm:w-full sm:max-w-lg">
+          <div class="bg-white px-4 pt-5 pb-4 sm:p-6 sm:pb-4">
+            <div class="sm:flex sm:items-start">
+              <div class="mx-auto flex h-12 w-12 flex-shrink-0 items-center justify-center rounded-full bg-blue-100 sm:mx-0 sm:h-10 sm:w-10">
+                <i data-lucide="copy" class="h-6 w-6 text-blue-600"></i>
+              </div>
+              <div class="mt-3 text-center sm:mt-0 sm:ml-4 sm:text-left">
+                <h3 class="text-lg font-medium leading-6 text-gray-900" id="modal-title">
+                  Dupliquer l'événement
+                </h3>
+                <div class="mt-2">
+                  <p class="text-sm text-gray-500">
+                    Choisissez les options de duplication pour "<%= @event.name %>".
+                  </p>
+                  
+                  <div class="mt-4">
+                    <div class="flex items-center">
+                      <input data-event-duplication-target="cloneTicketTypes" id="cloneTicketTypes" type="checkbox" class="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" checked>
+                      <label for="cloneTicketTypes" class="ml-2 block text-sm text-gray-900">
+                        Dupliquer également les types de billets (<%= @event.ticket_types.count %> type(s))
+                      </label>
+                    </div>
+                  </div>
+                </div>
+              </div>
+            </div>
+          </div>
+          <div class="bg-gray-50 px-4 py-3 sm:flex sm:flex-row-reverse sm:px-6">
+            <button type="button" data-action="click->event-duplication#duplicate" class="inline-flex w-full justify-center rounded-md border border-transparent bg-blue-600 px-4 py-2 text-base font-medium text-white shadow-sm hover:bg-blue-700 focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-2 sm:ml-3 sm:w-auto sm:text-sm">
+              Dupliquer
+            </button>
+            <button type="button" data-action="click->event-duplication#close" class="mt-3 inline-flex w-full justify-center rounded-md border border-gray-300 bg-white px-4 py-2 text-base font-medium text-gray-700 shadow-sm hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-indigo-500 focus:ring-offset-2 sm:mt-0 sm:ml-3 sm:w-auto sm:text-sm">
+              Annuler
+            </button>
+          </div>
+        </div>
+      </div>
+    </div>
+  </div>
 </div>