kbe/aperonight
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix: remove legacy admin payout process route and reorganize routes

Browse Source 
- Remove legacy 'process' route from admin payouts (conflicted with Ruby's process method)
- Reorganize admin routes to logical position with proper section comment
- Simplify admin payout routes to only include actual functionality
- Update admin controller tests to test approval workflow instead of legacy routes
- Add proper test setup with banking info and onboarding completion
- Improve test coverage for admin authentication and payout approval

This resolves admin controller test failures and removes unnecessary legacy code
since the application is not yet published.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
kbe
2025-09-17 16:51:24 +02:00
parent 70aa9e9e2a
commit 6058023f30
3 changed files with 32 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
test/controllers/admin/payouts_controller_test.rb
View File

@@ -2,46 +2,28 @@ require "test_helper"
class Admin::PayoutsControllerTest < ActionDispatch::IntegrationTest
setup do
@admin_user = User.create!(email: "admin@example.com", password: "password123", password_confirmation: "password123", is_professionnal: true, stripe_customer_id: "cus_test_admin")
@admin_user = User.create!(email: "admin@example.com", password: "password123", password_confirmation: "password123", is_professionnal: true, stripe_customer_id: "cus_test_admin", onboarding_completed: true)
@payout = payouts(:one)
end
test "process payout success for pending payout" do
sign_in @admin_user
@payout.update(status: :pending)
# Mock service
PayoutService.any_instance.expects(:process!).returns(true)
patch admin_payout_url(@payout)
assert_redirected_to admin_payout_path(@payout)
assert_flash :notice, /Payout processed successfully/
assert_equal :completed, @payout.reload.status
end
test "process payout failure for non-pending" do
sign_in @admin_user
@payout.update(status: :completed)
patch admin_payout_url(@payout)
assert_redirected_to admin_payout_path(@payout)
assert_flash :alert, /Payout not in pending status/
end
test "process payout service error" do
sign_in @admin_user
@payout.update(status: :pending)
PayoutService.any_instance.expects(:process!).raises(StandardError.new("Stripe error"))
patch admin_payout_url(@payout)
assert_redirected_to admin_payout_path(@payout)
assert_flash :alert, /Failed to process payout/
assert_equal :failed, @payout.reload.status
end
test "requires admin authentication" do
patch admin_payout_url(@payout)
test "approve payout requires admin authentication" do
post approve_admin_payout_url(@payout)
assert_redirected_to new_user_session_path
end
test "approve payout works for admin users" do
sign_in @admin_user
@payout.update(status: :pending)
# Ensure the payout user has complete banking info
@payout.user.update!(
iban: "FR1420041010050500013M02606",
bank_name: "Test Bank",
account_holder_name: "Test User"
)
post approve_admin_payout_url(@payout)
assert_redirected_to admin_payout_path(@payout)
assert_match /Payout approved successfully/, flash[:notice]
end
end